feat(permissionless batches): recovery mode after permissionless batches #1073

jonastheis · 2024-10-17T09:34:50Z

1. Purpose or design rationale of this PR

This PR implements a recovery mode after batches have been submitted permissionlessly in the context of permissionless batches. During permissionless mode the L2 network will not produce any valid/canonical L2 chain. Batches can be submitted by anyone directly to the L1.

This PR extends the L1 follower mode to be able to recover state from any given L1 block height --da.recovery.initiall1block and batch index --da.recovery.initialbatch to a given L2 end block --da.recovery.l2endblock, while overriding any existing local state of the node.

Additionally, it allows to re-sign the read blocks with --da.recovery.signblocks so that once the sequencer comes back online a valid canonical L2 chain can again be created from the permissionless committed batches.

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
docs: Documentation-only changes
feat: A new feature
fix: A bug fix
perf: A code change that improves performance
refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
test: Adding missing tests or correcting existing tests

3. Deployment tag versioning

Has the version in params/version.go been updated?

This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
Yes

4. Breaking change label

Does this PR have the breaking-change label?

This PR is not a breaking change
Yes

…initial batch from which point the existing local chain will be overridden with the blocks from the pipeline

…ow consumption

coderabbitai · 2024-11-05T23:12:56Z

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

…overy

semgrep-app · 2024-11-18T08:51:05Z

Semgrep found 1 ssc-46663897-ab0c-04dc-126b-07fe2ce42fb2 finding:

cmd/utils/flags.go
- L2423 - Triage

Risk: Affected versions of golang.org/x/net, golang.org/x/net/http2, and net/http are vulnerable to Uncontrolled Resource Consumption. An attacker may cause an HTTP/2 endpoint to read arbitrary amounts of header data by sending an excessive number of CONTINUATION frames.

Fix: Upgrade this library to at least version 0.23.0 at go-ethereum/go.mod:145.

Reference(s): GHSA-4v7x-pqxf-cx7m, CVE-2023-45288

_{Ignore this finding from ssc-46663897-ab0c-04dc-126b-07fe2ce42fb2.}

georgehao · 2024-11-19T08:36:23Z

cmd/geth/main.go

@@ -39,7 +41,6 @@ import (
 	"github.com/scroll-tech/go-ethereum/log"
 	"github.com/scroll-tech/go-ethereum/metrics"
 	"github.com/scroll-tech/go-ethereum/node"
-	"go.uber.org/automaxprocs/maxprocs"


don't change this

colinlyguo · 2024-11-19T08:35:38Z

rollup/da_syncer/da_syncer.go

-	if s.blockchain.CurrentBlock().Number.Uint64()%1000 == 0 {
-		log.Info("L1 sync progress", "blockhain height", s.blockchain.CurrentBlock().Number.Uint64(), "block hash", s.blockchain.CurrentBlock().Hash(), "root", s.blockchain.CurrentBlock().Root)
+	if s.asyncChecker != nil {
+		_ = s.asyncChecker.Check(fullBlock)


There seems to be no need to handle errors. what about handling errors here like printing some logs or removing error returns in asyncChecker.Check?

colinlyguo · 2024-11-19T09:04:22Z

rollup/da_syncer/da_syncer.go

+		return fmt.Errorf("failed getting parent block, number: %d", parentBlockNumber)
+	}
+
+	fullBlock, _, err := s.blockchain.BuildAndWriteBlock(parentBlock, block.PartialHeader.ToHeader(), block.Transactions, sign)


interesting. WriteStatus seems never been handled in the codebase.

colinlyguo · 2024-11-19T09:15:31Z

rollup/da_syncer/syncing_pipeline.go

+	RecoveryMode   bool   // Recovery mode is used to override existing blocks with the blocks read from the pipeline and start from a specific L1 block and batch
+	InitialL1Block uint64 // L1 block in which the InitialBatch was committed (or any earlier L1 block but requires more RPC requests)
+	InitialBatch   uint64 // Batch number from which to start syncing and overriding blocks
+	SignBlocks     bool   // Whether to sign the blocks after reading them from the pipeline (requires correct Clique signer key) and history of blocks with Clique signatures


could this be a mandatory mode? That is, any considerations to set it as a flag since it seems to be deducible by "produce block" and "sync from da" mode?

colinlyguo · 2024-11-19T09:23:03Z

core/blockchain.go

+		return nil, NonStatTy, fmt.Errorf("error validating block %d: %w", fullBlock.Number().Uint64(), err)
+	}
+
+	writeStatus, err := bc.writeBlockAndSetHead(fullBlock, receipts, logs, statedb, false)


Would set emitHeadEvent as true help clear the txn pool?

jonastheis added 4 commits October 16, 2024 11:56

add recovery mode to pipeline: allow specifying initial L1 block and …

66bddc5

…initial batch from which point the existing local chain will be overridden with the blocks from the pipeline

add optional signing of blocks

605da8b

add config option for L2EndBlock

20caa19

add CLI flags for new config values

eb6df8a

jonastheis marked this pull request as draft October 17, 2024 09:35

jonastheis changed the title ~~feat: recovery mode after permissionless batches~~ feat(permissionless batches): recovery mode after permissionless batches Nov 4, 2024

enable CCC in L1 follower node when --ccc flag is set to generate r…

b23eb93

…ow consumption

sanity check configuration when running in recovery mode

afdc961

jonastheis mentioned this pull request Nov 18, 2024

feat(permissionless batches): block production without signature #1087

Draft

13 tasks

Merge branch 'syncUpstream/active' into jt/permissionless-batches-rec…

86aa203

…overy

georgehao reviewed Nov 19, 2024

View reviewed changes

colinlyguo reviewed Nov 19, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(permissionless batches): recovery mode after permissionless batches #1073

feat(permissionless batches): recovery mode after permissionless batches #1073

jonastheis commented Oct 17, 2024

coderabbitai bot commented Nov 5, 2024 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

semgrep-app bot commented Nov 18, 2024

georgehao Nov 19, 2024

colinlyguo Nov 19, 2024

colinlyguo Nov 19, 2024

colinlyguo Nov 19, 2024 •

edited

Loading

colinlyguo Nov 19, 2024

feat(permissionless batches): recovery mode after permissionless batches #1073

Are you sure you want to change the base?

feat(permissionless batches): recovery mode after permissionless batches #1073

Conversation

jonastheis commented Oct 17, 2024

1. Purpose or design rationale of this PR

2. PR title

3. Deployment tag versioning

4. Breaking change label

coderabbitai bot commented Nov 5, 2024 • edited Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

semgrep-app bot commented Nov 18, 2024

georgehao Nov 19, 2024

Choose a reason for hiding this comment

colinlyguo Nov 19, 2024

Choose a reason for hiding this comment

colinlyguo Nov 19, 2024

Choose a reason for hiding this comment

colinlyguo Nov 19, 2024 • edited Loading

Choose a reason for hiding this comment

colinlyguo Nov 19, 2024

Choose a reason for hiding this comment

coderabbitai bot commented Nov 5, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

colinlyguo Nov 19, 2024 •

edited

Loading